Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfers: wrap amount to avoid csv parsing errors #894

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Transfers: wrap amount to avoid csv parsing errors #894

merged 1 commit into from
Jul 2, 2019

Conversation

AquiGorka
Copy link
Contributor

@AquiGorka AquiGorka commented Jul 2, 2019 •
edited
Loading

The commas from the formatted amount were breaking the csv, by wrapping with " this does not happen anymore.

Ref: #893

bpierre
bpierre approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@AquiGorka AquiGorka merged commit bca01c8 into master Jul 2, 2019
@AquiGorka AquiGorka deleted the fix/export branch July 2, 2019 14:43
@sohkai sohkai mentioned this pull request Jul 3, 2019
Closed
@luisivan luisivan removed request for luisivan, 2color and sohkai July 9, 2019 09:01
@luisivan luisivan added this to the Sprint 21 milestone Jul 9, 2019
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@AquiGorka
Transfers: wrap amount to avoid csv parsing errors (aragon#894)
660afd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpierre bpierre bpierre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 21
Development

Successfully merging this pull request may close these issues.
3 participants
@AquiGorka @bpierre @luisivan